Skip to content

DO NOT MERGE testing code reviewer #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tarekziade wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

DO NOT MERGE testing code reviewer #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions reviewbot/llm_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ def completion_tokens(self) -> Optional[int]:
return v if isinstance(v, int) else None


class AddingSomethingUseless:

@github-actions github-actions Bot Apr 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This AddingSomethingUseless class appears to serve no functional purpose. If it's a placeholder or test, it should be removed or properly documented. Unused code increases maintenance burden.

@github-actions github-actions Bot Apr 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code: this class and the module-level instantiation p below serve no purpose and run on every import, adding unnecessary side effects and clutter. Please remove both.

@github-actions github-actions Bot Apr 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class and the module-level instantiation below are unused dead code. The instance p is created at import time, causing unnecessary side effects and polluting the module namespace. Please remove this.

@github-actions github-actions Bot Apr 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code: AddingSomethingUseless serves no purpose and is never referenced. Remove unused classes.

@github-actions github-actions Bot Apr 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code: AddingSomethingUseless has no purpose, no callers, no tests, and no documentation. Adding unused classes to production infrastructure code creates maintenance burden and namespace pollution. Remove this class entirely.

@github-actions github-actions Bot Apr 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code: AddingSomethingUseless has no methods, no behavior, and no consumers. It should not be added to the production codebase.

@github-actions github-actions Bot Apr 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is not referenced anywhere else in the repository (only at line 51 in this same file). While the PascalCase naming does match the existing class style in reviewbot/, this is clearly dead code that should not be merged.

@sergereview sergereview Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code: this class is unused and appears to be test scaffolding. It should not be committed to the production module.

@sergereview sergereview Bot Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be dead code. The class and the module-level instantiation below (p = AddingSomethingUseless()) serve no purpose and create an import-time side effect. Please remove the entire added block.

@sergereview sergereview Bot Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code. A class explicitly named AddingSomethingUseless has no place in the production codebase and should be removed.

@sergereview sergereview Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code. This class has no purpose and should not be committed to a production module.

@sergereview sergereview Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class appears to be dead code with no functional purpose. It should be removed before merging.

Suggested change
class AddingSomethingUseless:

@sergereview sergereview Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is unused anywhere in the codebase. Dead code adds maintenance burden and should be removed.

Suggested change
class AddingSomethingUseless:

@sergereview sergereview Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code: this class is not referenced anywhere and serves no purpose in the codebase. It should be removed.

@sergereview sergereview Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class and the instance below are dead code with no functional purpose. Please remove AddingSomethingUseless and the global p instance before merging.

pass


p = AddingSomethingUseless()

@github-actions github-actions Bot Apr 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instantiation of AddingSomethingUseless on line 14 is unnecessary. If this is for testing, consider using proper test frameworks or removing dead code.

@github-actions github-actions Bot Apr 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexplained global state: p is instantiated at module import time but never used. This causes side effects on import and pollutes the namespace for no reason. Remove.

@github-actions github-actions Bot Apr 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code: module-level instantiation p = AddingSomethingUseless() serves no function and executes on every import. This is a side-effecting dead variable that wastes memory and confuses readers. Remove this line entirely.

@github-actions github-actions Bot Apr 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module-level instance executes at import time, creating an unnecessary side effect and polluting the module namespace. Remove this unused object.

@github-actions github-actions Bot Apr 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused module-level instantiation of a useless class. This is dead code with no purpose and should be removed.

@sergereview sergereview Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module-level instantiation runs at import time, wastes resources, and pollutes the module namespace. Please remove both the class and this line.

@sergereview sergereview Bot Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module-level instantiation is an anti-pattern: it triggers side effects on import and leaks a global variable into the module namespace. Please remove.

@sergereview sergereview Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module-level instantiation creates an object at import time with no purpose. Remove this dead code.

@sergereview sergereview Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module-level dead code that instantiates a useless class. This pollutes the module namespace and serves no purpose. Remove before merging.

Suggested change
p = AddingSomethingUseless()

@sergereview sergereview Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module-level instantiation causes a side effect on every import of this module. Even if the class were useful, this should not happen at the top level. Please remove.

@sergereview sergereview Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module-level side effect: instantiating an object at import time causes unnecessary work on every module import and pollutes the global namespace. If this is test code, it should not be merged.



class ChatCompletionClient:
"""Minimal OpenAI-compatible /v1/chat/completions client.

Expand Down