Added encode args to be used during eval#3480
Added encode args to be used during eval#3480sw241395 wants to merge 2 commits intohuggingface:mainfrom
Conversation
|
It seems like the tests are failing due to: Too many requests I suspect from the github/containers IP. I have run them locally and the seems to be ok. A temporary work around could be to include the model in the tests folderstructure, then during the set up of the tests copy them into the appropriate .cache dir. But i understand this is quite hacky and not great practice. |
|
Hello! Thank you for opening this. Indeed, the test failures are due to rate limits from the various GitHub actions runners. It's unrelated to this PR.
Or perhaps we recognize that if a model is custom, then we don't necessarily have 100% compatibility with the rest of the library, and users of those custom models are expected to make the required changes on their side?
|
Hey Tom Yeah I agree that custom models wont have 100% compatibility to the library. I am happy to move the args to the init if you feel this is more appropriate. Ive seen in some of the inits they already have args that are used in the call so kinda makes sense too be consistent in that manor. Unless you prefer to leave it in the call method then I can go back and fix the InformationRetievalEvaluator. Thanks |
In some of the eval methods, you can't pass args to the encode method.
Therefore I made some edits too the eval code to enable it.
This will be useful for some think like the jinaai/jina-embeddings-v3 model where you pass in the LoRA adapter you want to use.
Let me know if you want me to change anything.