Add merge_adapter method to PeftAdapterMixin to safely merge PEFT adapters (#3247)#3339
Open
MrAnayDongre wants to merge 2 commits intohuggingface:mainfrom
Open
Add merge_adapter method to PeftAdapterMixin to safely merge PEFT adapters (#3247)#3339MrAnayDongre wants to merge 2 commits intohuggingface:mainfrom
MrAnayDongre wants to merge 2 commits intohuggingface:mainfrom
Conversation
Member
|
Hello! Apologies for the huge delay. I never made progress with this, because I don't believe that the
|
tomaarsen
requested changes
Dec 9, 2025
Member
tomaarsen
left a comment
tomaarsen
left a comment
There was a problem hiding this comment.
See the above, I believe the merge_and_unload often (always?) doesn't exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a
merge_adaptermethod that checks for a callablemerge_and_unloadon the underlying model. If found, it merges the adapter and resets the configuration flag; otherwise, it raises a clear error. Tests cover both success and failure cases.