Fix #3185: Support convert_to_numpy for output_value="token_embeddings"#3186
Open
bhavnicksm wants to merge 3 commits intohuggingface:mainfrom
Open
Fix #3185: Support convert_to_numpy for output_value="token_embeddings"#3186bhavnicksm wants to merge 3 commits intohuggingface:mainfrom
convert_to_numpy for output_value="token_embeddings"#3186bhavnicksm wants to merge 3 commits intohuggingface:mainfrom
Conversation
Member
|
Hello! I added some tests so that the current behaviour is pretty much what is expected. Sadly, there's an issue with the expected output if the But for now, perhaps we can re-add the removed code, but with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey UKPLab and ST Team! 👋
Just added a fix for #3185
Let me know if it looks good or any changes I need to make to the PR!
Thanks 😊
cc: @tomaarsen