-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[NPU] npu attention enable ulysses #12919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+76
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@yiyixuxu @sayakpaul Hello, could you please review this pr, tks. |
Signed-off-by: yyt <[email protected]>
…dant transpose Signed-off-by: yyt <[email protected]>
sayakpaul
approved these changes
Jan 8, 2026
Member
|
@bot /style |
Contributor
|
Style fix is beginning .... View the workflow run here. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
can you take a look again? |
Member
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The original npu attention backend in diffusers does not support ulysses parallel yet. This PR is to implement the ulysses parallel attention for npu attention backend.
Note: Only implement forward op now, the backward op is not supported now.
Test
Hardware
Atlas 800T A2
Repro Code
Result
1. no ulysses attention
Command
Inference Time:
24.44s
Result Image:

2. ulysses attention with degree 2
Command:
Inference Time:
18.83s
Result Image:

3. ulysses attention with degree 4
Command:
Inference Time:
12.69s
Result Image:

Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.