Skip to content

Conversation

@Teriks
Copy link
Contributor

@Teriks Teriks commented Sep 17, 2025

In sdxl advanced dreambooth training script

vae.config.scaling_factor becomes inaccessible after: del vae

when: --cache_latents, and no --validation_prompt

What does this PR do?

Fixes a non-existent attribute reference with a particular argument combination.

Before submitting

Who can review?

@sayakpaul

In sdxl advanced dreambooth training script

vae.config.scaling_factor becomes inaccessible after: del vae

when: --cache_latents, and no --validation_prompt
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@linoytsaban linoytsaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jan 9, 2026
@iwr-redmond
Copy link

Ping to remove stale

@yiyixuxu yiyixuxu added close-to-merge and removed stale Issues that haven't received updates labels Jan 9, 2026
@yiyixuxu yiyixuxu merged commit 57e57cf into huggingface:main Jan 9, 2026
24 of 26 checks passed
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Jan 9, 2026

thanks for the PR! sorry we let it go stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants