refactor(libcommon): remove now obsolete get_supported_unsupported_columns() function
#3252
+12
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
changed the title
get_supported_unsupported_columns\(\) functionget_supported_unsupported_columns() function
kszucs
changed the title
get_supported_unsupported_columns() functionget_supported_unsupported_columns() function
kszucs
force-pushed
the
supported-unsupported-features
branch
2 times, most recently
from
9ea174b to
a012b36
Compare
lhoestq
approved these changes
Nov 4, 2025
…olumns\(\)` function
kszucs
force-pushed
the
supported-unsupported-features
branch
from
a012b36 to
b15a331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3251
Apparently
get_supported_unsupported_columns()is always called with emptyunsupported_featuresargument, so it always returns withlist(features.keys()).