Skip to content

Fix navigation toggle button animation #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix navigation toggle button animation #1929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e77814
nav adjustments wip
TGlide Oct 8, 2025
d83445b
fix toggle button animation
TGlide Oct 8, 2025
ed0d9ee
fix overflow
TGlide Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/components/ExpandNavigation.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<button
onclick={onClick}
class="{classNames} group flex h-16 w-6 flex-col items-center justify-center -space-y-1 outline-none *:h-3 *:w-1 *:rounded-full *:hover:bg-gray-300 dark:*:hover:bg-gray-600 max-md:hidden {!isCollapsed
class="{classNames} group flex h-16 w-6 flex-col items-end justify-center -space-y-1 outline-none *:h-3 *:w-1 *:rounded-full *:hover:bg-gray-300 dark:*:hover:bg-gray-600 max-md:hidden {!isCollapsed
? '*:bg-gray-200/70 dark:*:bg-gray-800'
: '*:bg-gray-200 dark:*:bg-gray-700'}"
name="sidebar-toggle"
Expand Down
43 changes: 22 additions & 21 deletions src/routes/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,18 +241,12 @@
<BackgroundGenerationPoller />

<div
class="fixed grid h-full w-screen grid-cols-1 grid-rows-[auto,1fr] overflow-hidden text-smd {!isNavCollapsed
? 'md:grid-cols-[290px,1fr]'
: 'md:grid-cols-[0px,1fr]'} transition-[300ms] [transition-property:grid-template-columns] dark:text-gray-300 md:grid-rows-[1fr]"
class={[
"fixed grid h-full w-screen grid-cols-1 grid-rows-[auto,1fr] overflow-hidden text-sm",
isNavCollapsed ? "md:grid-cols-[0px,1fr]" : "md:grid-cols-[290px,1fr]",
"transition-[300ms] [transition-property:grid-template-columns] dark:text-gray-300 md:grid-rows-[1fr]",
]}
>
<ExpandNavigation
isCollapsed={isNavCollapsed}
onClick={() => (isNavCollapsed = !isNavCollapsed)}
classNames="absolute inset-y-0 z-10 my-auto {!isNavCollapsed
? 'left-[290px]'
: 'left-0'} *:transition-transform"
/>

{#if canShare}
<button
type="button"
Expand All @@ -273,17 +267,24 @@
oneditConversationTitle={(payload) => editConversationTitle(payload.id, payload.title)}
/>
</MobileNav>
<nav
class="grid max-h-screen grid-cols-1 grid-rows-[auto,1fr,auto] overflow-hidden *:w-[290px] max-md:hidden"
>
<NavMenu
{conversations}
user={data.user}
canLogin={!data.user && data.loginEnabled}
ondeleteConversation={(id) => deleteConversation(id)}
oneditConversationTitle={(payload) => editConversationTitle(payload.id, payload.title)}
<div class="relative max-h-screen max-md:hidden">
<nav
class="grid max-h-screen grid-cols-1 grid-rows-[auto,1fr,auto] overflow-hidden *:w-[290px]"
>
<NavMenu
{conversations}
user={data.user}
canLogin={!data.user && data.loginEnabled}
ondeleteConversation={(id) => deleteConversation(id)}
oneditConversationTitle={(payload) => editConversationTitle(payload.id, payload.title)}
/>
</nav>
<ExpandNavigation
isCollapsed={isNavCollapsed}
onClick={() => (isNavCollapsed = !isNavCollapsed)}
classNames="absolute inset-y-0 -right-2 z-10 my-auto *:transition-transform"
/>
</nav>
</div>
{#if currentError}
<Toast message={currentError} />
{/if}
Expand Down
Loading