Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔴 NOT READY TO BE MERGED] Unit 1 Updates #31

Merged
merged 182 commits into from
Feb 10, 2025
Merged

[🔴 NOT READY TO BE MERGED] Unit 1 Updates #31

merged 182 commits into from
Feb 10, 2025

Conversation

simoninithomas
Copy link
Member

@simoninithomas simoninithomas commented Feb 5, 2025

This is the working PR for Joffrey and me to update the sections and add the illustrations.

Before a final review of the team 🤗

Not ready to be reviewed yet.

@pcuenca
Copy link
Member

pcuenca commented Feb 6, 2025

Opened this PR to suggest modifications to this branch as I go through it.

@Jofthomas
Copy link
Collaborator

thanks @sergiopaniego applied your suggestions

@simoninithomas
Copy link
Member Author

We're merging this PR, because it's too big, if we need change let's open a new PR 🤗

Copy link
Collaborator

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@Jofthomas Jofthomas merged commit 6c5d8d1 into main Feb 10, 2025
1 check passed
@Jofthomas Jofthomas deleted the Unit_1_Joffrey branch February 10, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants