Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add star CTA #235

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Conversation

Jofthomas
Copy link
Collaborator

Hey,

A bit last minute, but let's add a CTA in the intro to ask students to like the smolagents repo !

cc : @sergiopaniego , @burtenshaw , @pcuenca , @aymeric-roucher

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@aymeric-roucher
Copy link
Collaborator

Thanks a lot!

Copy link
Collaborator

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Smolagents is a Hugging Face... --> smolagents is a Hugging Face...

@burtenshaw burtenshaw merged commit ca8d7dd into unit_2_1_smolagents Feb 25, 2025
1 check passed
@burtenshaw burtenshaw deleted the unit2.1_smolagents_Joffrey-review branch February 25, 2025 15:01
@Jofthomas
Copy link
Collaborator Author

You're right @sergiopaniego , but since it's at the start of the sentence it felt weird.

@Jofthomas
Copy link
Collaborator Author

maybe a question for @aymeric-roucher ? Is it always a lowercase "s" at the start ?

@aymeric-roucher
Copy link
Collaborator

aymeric-roucher commented Feb 25, 2025

I asked myself the same question! Indeed it seems weird to write in samaltmancase, so here I'd say it can stay uppercase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants