-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for "db types" #115
base: master
Are you sure you want to change the base?
Conversation
@@ -9,6 +9,8 @@ | |||
</button> | |||
<div *ngIf="adding"> | |||
<input type="text" placeholder="user:password@hostname:port" [(ngModel)]="newServer" [disabled]="loading" /> | |||
<input type="text" placeholder="URL to retrieve server types" [(ngModel)]="newTypesUrl" | |||
[disabled]="loading" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this could be controlled by an env var?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not mandatory, but yes why not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(im wondering if some other people are using Mongoku in prod btw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be some "experimental" feature flag maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm not sure it's worth the hassle for one feature, this is old technology we're working with here - no simple way to pass the value of a server-side env var to the front
This PR adds the ability to retrieve the "types" associated with the collections of a db from a remote service (one URL per server), allowing to link between documents from different collections.
See
Mongoku/lib/Database.ts
Lines 17 to 32 in 25492ac