Skip to content

WIP: Add Elastic exporter - #233

Closed
papey wants to merge 13 commits into
hubblo-org:devfrom
papey:92-add-es-exporter
Closed

WIP: Add Elastic exporter#233
papey wants to merge 13 commits into
hubblo-org:devfrom
papey:92-add-es-exporter

Conversation

@papey

@papey papey commented Nov 5, 2022

Copy link
Copy Markdown

Context

This PR adds Elastic search as a new exporter for Scaphandre. Linked to #92.

Comment thread src/main.rs Outdated
Comment thread Cargo.toml Outdated
@uggla

uggla commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator

A couple of advice, I think you should work with the dev branch. Because there are a lot of changes coming up with this release, it will later ease your rebase. Although I don't know when @bpetit plan to release it.
Take care #234 will bring clap 4. And the way to declare command line arguments will change. So I think you can temporary get the #234 commits for your development and remove them as soon as they will be merged. (assuming they will be merged).

@papey

papey commented Nov 7, 2022

Copy link
Copy Markdown
Author

A couple of advice, I think you should work with the dev branch. Because there are a lot of changes coming up with this release, it will later ease your rebase. Although I don't know when @bpetit plan to release it. Take care #234 will bring clap 4. And the way to declare command line arguments will change. So I think you can temporary get the #234 commits for your development and remove them as soon as they will be merged. (assuming they will be merged).

Thanks for the early feedback, I will rebase my branch against dev, and set dev as target branch for this PR.

I will also look for clap 4 stuff early since you will probably merge your PR before mine. 👍

@papey
papey changed the base branch from main to dev November 8, 2022 07:52
@papey

papey commented Nov 8, 2022

Copy link
Copy Markdown
Author

I will watch for main > dev sync in order to remove the non-related commits.

@papey

papey commented Mar 11, 2023

Copy link
Copy Markdown
Author

👋 everyone, hope you are doing well. I finally have time to work on this PR 🤞 !

Here is some basic stuff, with all the internal Scaphandre metrics. I'll probably rename it a bit.

Here is, IMO, the next steps :

  • Rework a bit the naming for scaphandre "self" data
  • Add an index for the sockets part, push the socket data
  • Add an index for the procs part, push the procs data

After that it should be ready for review !

@papey papey closed this by deleting the head repository Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To do

Development

Successfully merging this pull request may close these issues.

3 participants