Skip to content

Fix header append #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2020
Merged

Fix header append #141

merged 2 commits into from
May 21, 2020

Conversation

yoshuawuyts
Copy link
Member

Addresses some of the inconsistencies pointed out by http-rs/tide#520. Thanks!

@yoshuawuyts yoshuawuyts requested a review from jbr May 21, 2020 00:05
jbr
jbr approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems quite reasonable to me! Maybe docs should communicate the circumstances in which these methods would panic? Am I right that it's pretty much a matter of string encoding and should be very unlikely for anyone to run into?

@yoshuawuyts
Copy link
Member Author

Am I right that it's pretty much a matter of string encoding and should be very unlikely for anyone to run into?

Yes, accurate. That's the only case. We'll never panic however if a valid HeaderValue / HeaderName has been provided already, which provides a way to construct values with the errors handled.

@yoshuawuyts yoshuawuyts merged commit aeb1fb4 into master May 21, 2020
@yoshuawuyts yoshuawuyts deleted the fix-header-append branch May 22, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbr jbr jbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshuawuyts @jbr