Add tests to increase spec coverage #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse5 is now tracking the test coverage of its codebase. The tests here all cover areas that previously didn't have tests.
fb55
commented
May 20, 2022
gsnedders
reviewed
Mar 23, 2023
|
Thanks for the review @gsnedders, made the requested changes. I would like to wait for the open PRs for #141 to be landed before this one, to make sure I didn't mess up subtleties around errors. |
gsnedders
approved these changes
Aug 13, 2023
|
(Let me know if you do indeed think this is ready to land.) |
Ms2ger
reviewed
Aug 16, 2023
Co-authored-by: Mike Dalessio <[email protected]>
|
This should now be ready to land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse5 is now tracking the test coverage of its codebase. The tests here all cover areas that previously didn't have tests.