Skip to content

Commit

Permalink
tweak docker build
Browse files Browse the repository at this point in the history
  • Loading branch information
hsheth2 committed Dec 15, 2024
1 parent bdca6cb commit 2091692
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 27 deletions.
32 changes: 16 additions & 16 deletions .github/workflows/docker-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Docker Images CI

on:
push:
branches: [ main ]
branches: [main]
pull_request:
branches: [ main ]
branches: [main]

permissions:
contents: read
Expand All @@ -17,18 +17,18 @@ jobs:
PUSH_IMAGES: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}

steps:
- uses: actions/checkout@v2
- name: Build the Docker images
run: docker-compose build

- name: Log in to the Container registry
if: ${{ env.PUSH_IMAGES == 'true' }}
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/checkout@v4
- name: Build the Docker images
run: docker compose build

- name: Publish the Docker images
if: ${{ env.PUSH_IMAGES == 'true' }}
run: docker-compose push
- name: Log in to the Container registry
if: ${{ env.PUSH_IMAGES == 'true' }}
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Publish the Docker images
if: ${{ env.PUSH_IMAGES == 'true' }}
run: docker compose push
16 changes: 7 additions & 9 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
{
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
},
"eslint.format.enable": true,
"eslint.packageManager": "yarn",
"eslint.workingDirectories": [
{"mode": "auto"}
]
}
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit"
},
"eslint.format.enable": true,
"eslint.packageManager": "yarn",
"eslint.workingDirectories": [{ "mode": "auto" }]
}
2 changes: 0 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
version: '2'

services:
frontend:
image: ghcr.io/hsheth2/ppa-stats-frontend:latest
Expand Down

0 comments on commit 2091692

Please sign in to comment.