Turn the break reason into an enum, fix some minor issues #20006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
the
Code Cleanup
hrydgard
force-pushed
the
break-reason-refactor
branch
from
5e98430 to
31cf577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report #20004 , while reporting on an old version of PPSSPP, made me take a look at Core_Break, and how brittle it is to use a string there, if we actually care about the break reason. So this just converts it to an enum, and sets it in a couple of cases where it wasn't set before. Next cleanup in this area will be to disallow direct access to coreState except by the JIT which needs it.
Now you can also see the break reason in the imdebugger.