Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: fix wayland swapchain size 1x1 #16219

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

catsout
Copy link
Contributor

@catsout catsout commented Oct 15, 2022

From Vulkan spec,
surfaceCapabilities.currentExtent can be 0xFFFFFFFF(-1)

Define a callback to get drawsize from window creator

relate:
https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkSurfaceCapabilitiesKHR.html
KhronosGroup/Vulkan-Docs#590 (comment)

issue:
#16163
#13845

From Vulkan spec,
surfaceCapabilities.currentExtent can be 0xFFFFFFFF(-1)

Define a callback to get drawsize from window creator

relate:
https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkSurfaceCapabilitiesKHR.html
KhronosGroup/Vulkan-Docs#590 (comment)
@catsout catsout force-pushed the fix-vulkan-wayland branch from c997ff6 to b0ceeed Compare October 15, 2022 11:03
Copy link
Owner

@hrydgard hrydgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch and a decent implementation. Let's get it in.

@hrydgard hrydgard enabled auto-merge October 15, 2022 20:35
@hrydgard hrydgard merged commit cd0cef7 into hrydgard:master Oct 15, 2022
@unknownbrackets unknownbrackets added this to the v1.14.0 milestone Oct 15, 2022
@unknownbrackets unknownbrackets added SDL2 Issue on SDL (or Qt in SDL code) but not all ports. Vulkan labels Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDL2 Issue on SDL (or Qt in SDL code) but not all ports. Vulkan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants