Skip to content

Conversation

callmephilip
Copy link

Newly generated sites are missing some dependencies:

  • react related jazz
  • next
  • nextra

This PR adds missing dependencies in the package.json generation phase so the newly minted site works right away

Copy link

@eugene-yaroslavtsev eugene-yaroslavtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! Also thanks for actually running biome on this and eliminating those naughty extra commas 😅

Not sure if we should use latest cuz it might break on major version bump but let’s YOLO for now 🤠

Copy link

@eugene-yaroslavtsev eugene-yaroslavtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops just noticed there’s a merge conflict - mind fixing that? 🙇

@callmephilip
Copy link
Author

Oops just noticed there’s a merge conflict - mind fixing that? 🙇

should be good now. reran biome as well. 🖖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants