Skip to content

Conversation

@Banibrata-Manna
Copy link

Related Issue: #429

Added App Bridge Login Flow for Shopify Embedded App User Login. And removed usage of getAppLoginUrl from DxpLogin since it's not needed on DxpLogin now.

@Banibrata-Manna Banibrata-Manna marked this pull request as draft September 8, 2025 15:18
@ravilodhi
Copy link
Contributor

ravilodhi commented Sep 10, 2025

@gemini-code-assist please review this PR.

@gemini-code-assist
Copy link

Hello! You've tagged me. How can I assist you with this pull request?

If you'd like a code review, please use /gemini review. For a summary of the pull request, use /gemini summary. You can also type /gemini help to see all available commands.

@Banibrata-Manna Banibrata-Manna marked this pull request as ready for review September 10, 2025 11:17
@ravilodhi
Copy link
Contributor

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a login flow for embedded Shopify apps using App Bridge. The changes are mostly in DxpLogin.vue and new utility functions in src/utils/index.ts.

My review has identified a few critical and high-severity issues:

  • A critical logic bug in the new openPosScanner utility function will cause it to not work as expected.
  • The project now depends on @shopify/app-bridge-utils, which is a deprecated package and should be replaced.
  • There's a potential for an unhandled exception in DxpLogin.vue due to unsafe parsing of an environment variable.

Additionally, I've pointed out several medium-severity issues, including leftover console.log statements, throwing strings instead of Error objects, and a confusing TODO comment. Please address these points to improve the code's robustness and maintainability.

@Banibrata-Manna
Copy link
Author

Related PRs

Fulfillment - hotwax/fulfillment#1352
Receiving - hotwax/receiving#549
inventory-count - hotwax/inventory-count#794
oms-api - hotwax/oms-api#122

@Banibrata-Manna
Copy link
Author

Shopify claims to use Socket mobile Scanners in Shopify POS and connect with them seemlessly and manage them in settings, it has been observed that if we connect a scanner with Shopify POS then that scanner only fills out the Shopify POS inputs and not the input fields in Shopify POS embedded apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants