Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conditional to skip 403 when creating datasets #18

Merged
merged 1 commit into from
Jul 10, 2024
+1 −1
Merged

fix conditional to skip 403 when creating datasets #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix conditional to skip 403 when creating datasets
@keyn4
keyn4 committed Jul 9, 2024
commit df19a39b38a30c56f1465951efaf6deb2357ffa4
2 changes: 1 addition & 1 deletion target_bigquery/utils.py
View file
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@ def ensure_dataset(project_id, dataset_id, location):
if e.response.status_code == 403:
logger.info(f"Skipping dataset validation due user does not have permission to create datasets. Using dataset id from config {dataset_id}")
pass
if e.response.status_code == 409: # dataset exists
elif e.response.status_code == 409: # dataset exists
pass
else:
logger.critical(f"unable to create dataset {dataset_id} in project {project_id}; Exception {e}")