Adding median proc-block adding more hints

[f0rodo]

No description provided.

[Michael-F-Bryan]

It's awesome to see you chugging away with your own proc blocks!

I think we should try to add some proper error handling to the kernel() function so we don't blow up the moment we leave the happy path.

I think I also found a bug in the implementation. Can you pull the business logic out into some sort of fn median(values: &ArrayView1<f64>) -> Option<f64> function and add some unit tests?

[Michael-F-Bryan]

There's a hell of a lot of unwrap()s in here. Is there any chance you can translate them into errors so the proc-block fails gracefully instead of ending up fubar.

As we implement more proc-blocks I'll introduce some convenience methods or abstractions to make error handling cleaner, but in the meantime the modulo implementation should give you some inspiration.

[Michael-F-Bryan]

You should be able to do the sorting in place. That way we don't copy the entire input tensor (the to_vec()) unnecessarily.

Maybe something like this?

Suggested change

	let samples: ArrayView1<f64> = match element_type {
	ElementType::F64 => buffer
	.view(&dimensions)
	.unwrap()
	.into_dimensionality()
	.unwrap(),
	_ => panic!("Handle invalid element type"),
	};
	let mut median_slice: Vec<f64> = samples.to_slice().unwrap().to_vec();
	median_slice.sort_by(|a, b| a.partial_cmp(b).unwrap());
	let median = (median_slice.len() as f32 / 2.0) as i32 as usize;
	ctx.set_output_tensor(
	"median",
	TensorParam {
	element_type: ElementType::F64,
	dimensions: &[1],
	buffer: [samples[median]].as_bytes(),
	},
	);
	let samples: ArrayViewMut1<f64> = match element_type {
	ElementType::F64 => buffer
	.view_mut(&dimensions)
	.unwrap()
	.into_dimensionality()
	.unwrap(),
	_ => panic!("Handle invalid element type"),
	};
	samples.as_slice_mut().unwrap().sort_by(|a, b| a.partial_cmp(b).unwrap());
	let median = (median_slice.len() as f32 / 2.0) as i32 as usize;
	ctx.set_output_tensor(
	"median",
	TensorParam {
	element_type: ElementType::F64,
	dimensions: &[1],
	buffer: [samples[median]].as_bytes(),
	},
	);

Also, the original code stored the sorted values in median_slice then proceeded to extract the median using samples[median]... Which is probably not what you wanted 😅