Two small fixes in the sfPropelPlugin for newer PHP versions #5
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -191,7 +191,7 @@ function resolveFile(PhingFile $f) { | |||
| /* -- most of the following is mapped to the php natives wrapped by FileSystem */ | |||
|
|
|||
| /* -- Attribute accessors -- */ | |||
| function getBooleanAttributes(&$f) { | |||
| function getBooleanAttributes($f) { | |||
There was a problem hiding this comment.
Is this related to the issue causing output when generating models?
There was a problem hiding this comment.
This has to do with this strict warning: PHP Strict standards: Declaration of UnixFileSystem::getBooleanAttributes() should be compatible with FileSystem::getBooleanAttributes($f) in code/lib/vendor/symfony/symfony1/lib/plugins/sfPropelPlugin/lib/vendor/phing/system/io/UnixFileSystem.php on line 278 during generation of the models yes.
|
@leonrenkema Thanks for the PR, I'll release a tag shortly. |
linaori
added a commit
that referenced
this pull request
Oct 7, 2014
Two small fixes in the sfPropelPlugin for newer PHP versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'v patched the sfPropelPlugin for newer versions of PHP that have deprecated mysql_escape_string