Google test #32
Open
Google test #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/tests following cudf & cugraph
…i throws exception.
…ctory at somepoint if I don't get complaints, let's remove unused files from the code base
…ph and cudf) and moved test files to the created directories
…e files for a while... (these files will eventually be removed once hornet gets integrated into cugraph)
… two unsigned integers, need to check a + b > a, not a + b < a
… so no need to have a separate command line test files
…TopDown and BfsTopDown2 classes
…o insert_delete_test.cu and updated insert_delete_test.cu to use Google test
…unnamed name space to avoid a Triangle2 class instance invoking the OPERATOR_InitTriangleCounts defined in triangle.cu (instead of the one in triangle2.cu)
…ctory at somepoint if I don't get complaints, let's remove unused files from the code base.
…on to TriangleCounting (it was TriangleCounting2)
…TopDown (it was BfsTopDown2)
…system with more than 8 GPUs due to a bug in the xlib library, I am planning to carve out the entire xlib library, so I may not fix this in a more appropriate way at this moment
…et inconsistently uses Google's convention in naming class member variables... this inconsistency needs to be fixed as well.
…h to inverted_graph_, this naming rule (adding trailing _) should be consistently enforced to every class in hornet, but we may do this sometime later
|
Added quick fixes for the FPE issue in systems with more than 8 GPUs and the KatzCentralityDynamic compile error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates hornet to use Google test. Test files will be located under build/gtests directory. Test files take command line arguments (e.g. graph file path) as before. Fixed several bugs on the way. Older versions of breadth-first-search and triangle-counting are replaced with the new ones (triangle2, bfs2, BfsTopDown2, and TriangleCounting2) and removed 2 from their names.