fix(render): drop shell:true from hyperframes spawn#3
Open
nguyentran4896 wants to merge 1 commit into
Open
Conversation
shell:true is a command-injection foot-gun: if any user-derived string ever flows into args, it would be interpreted by the shell. Args are all internal today so behaviour is unchanged, but removing the option now makes the codebase safer by default. On macOS/Linux npx resolves correctly via PATH without a shell wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
shell: truefrom thespawn("npx", spawnArgs, { ... })call insrc/render/hyperframes-runner.ts. Withshell: true, args are concatenated into a shell string, which is a foot-gun if any user-derived value ever flows into them. All current args are internal, so behavior is unchanged today — this is a defense-in-depth cleanup.npxresolves via PATH on macOS/Linux without a shell, verified with a quick smoke test.Test plan
npm run typecheckpassesnpm testpasses (44 tests)node -e "require('child_process').spawn('npx', ['--version'], {stdio:'inherit'})"prints npx version