-
Notifications
You must be signed in to change notification settings - Fork 20
fix(hoppscotch): fix auto generated desktop app whitelist origin #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(hoppscotch): fix auto generated desktop app whitelist origin #40
Conversation
781c002
to
9dcd336
Compare
@liyasthomas Can you confirm what should be whitelisted for the desktop app? Here's what I have based on the desktop app README. Assume I'm self-hosting Hoppscotch on Requirements:
If I were to manually configure whitelisted origins, it would look like this: hoppscotch:
backend:
whitelistedOrigins:
- https://hoppscotch.example.com
- app://hoppscotch_example_com
- http://app.hoppscotch_example_com Is this correct? Anything else to add? If not, then this PR is ready to go. |
f3f9f3a
to
d480325
Compare
d480325
to
7dc7053
Compare
7dc7053
to
c8537f6
Compare
1194162
to
dc39834
Compare
Yes, you are right. |
This PR resolves issues #38 and #43.
Issue #38 is resolved by updating the
hoppscotch.backend.whitelistedOrigins
named template to replace.
with_
for the desktop app origin. This fix includes unit test coverage and has been verified manually.Issue #43 is resolved by updating chart dependency versions and setting default image repositories to
bitnamilegacy/*
. This fix has been verified manually using e2e tests.