feat: Add resource limits to init container in database migration Job #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable resource limits and requests to Kubernetes containers in the Hoppscotch Enterprise Helm chart, including init containers, migration jobs, and the PostgreSQL database. The changes enable better resource management and prevent resource contention in Kubernetes clusters.
- Introduces resource configuration for init containers, migration jobs, and PostgreSQL database
- Makes resource limits and requests configurable through the values.yaml file
- Updates all relevant template files to use the new resource configurations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/she/values.yaml | Adds resource configuration sections for init containers, migration jobs, and PostgreSQL with default values |
| charts/she/templates/postgresql.yaml | Applies resource limits to the PostgreSQL container using values from configuration |
| charts/she/templates/migration-job.yaml | Adds resource limits to both init container and migration job container |
| charts/she/templates/deployment.yaml | Applies resource limits to init containers in the main deployment |
|
@nahidhasan94 Don’t we need the same things for SHC chart as well? |
mirarifhasan
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add resource limits and request to init container and database migration Job main container as well as in the postgresql statefulset. And resource value can be changed from the values file.
Checks