address PR #264 review comments - #276
Merged
GuiDupont merged 3 commits intoFeb 3, 2026
Merged
Conversation
- revert v0.5.0 file changes (import path and typo) - rename OperatorPrivileges to SafePrivileges for clarity - add maxCap() and gaveUpSafePrivileges() getters - update tests to reflect naming changes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jfrancai
force-pushed
the
fix/pr-264-review-comments
branch
from
February 3, 2026 03:19
9900f37 to
07ede6a
Compare
… to library - Replace onlyOperator(controller, bool) with two modifiers: - onlyOperator(controller): excludes safe as operator - onlyOperatorOrSafe(controller): includes safe as operator - Move _isOperator, _isSafeAnOperator logic to ERC7540Lib - Move _protocolFeeReceiver to RolesLib - Add isOperatorOrSafe() public view function - Remove _protocolFeeReceiver abstract function from ERC7540
jfrancai
force-pushed
the
fix/pr-264-review-comments
branch
from
February 3, 2026 04:07
07ede6a to
f2b6be6
Compare
GuiDupont
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.