Feat/blacklist - #269
Merged
Merged
Conversation
jfrancai
reviewed
Feb 2, 2026
| } | ||
|
|
||
| // ********************* WHITELISTABLE ********************* // | ||
| enum WhitelistState { |
Contributor
There was a problem hiding this comment.
I would name this AccessMode instead
| /// @notice Deactivates the whitelist | ||
| function disableWhitelist() public onlyOwner { | ||
| WhitelistableLib.disableWhitelist(); | ||
| function switchWhitelistMode( |
Contributor
There was a problem hiding this comment.
I would name this switchAccessMode
| event BlacklistActivated(); | ||
|
|
||
| /// @notice Emitted when the whitelist is switched to whitelist. | ||
| event WhitelistActivated(); |
Contributor
There was a problem hiding this comment.
we should only use one event with params like AccessModeUpdated(Whitelist/Blacklist)
|
|
||
| /// @notice Indicates that the whitelist is not activated. | ||
| /// @dev this error is not used in v0.6.0. | ||
| error WhitelistNotActivated(); |
Contributor
There was a problem hiding this comment.
I don't see this error being used if I'm not mistaken
| error WhitelistNotActivated(); | ||
|
|
||
| /// @notice Indicates that the whitelist/blacklist is disabled. | ||
| error AccessControlDisabled(); |
Contributor
There was a problem hiding this comment.
I don't see this error being used if I'm not mistaken
- Rename enum WhitelistState to AccessMode - Rename function switchWhitelistMode to switchAccessMode - Replace BlacklistActivated and WhitelistActivated events with single AccessModeUpdated(AccessMode) event - Remove unused errors WhitelistNotActivated and AccessControlDisabled Addresses review comments from PR #269. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
refactor: rename WhitelistState to AccessMode
jfrancai
force-pushed
the
feat/blacklist
branch
from
February 3, 2026 10:17
d0bffa0 to
09b1538
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.