Skip to content

Conversation

@3w36zj6
Copy link
Contributor

@3w36zj6 3w36zj6 commented Oct 28, 2025

In .github/workflows/ci-ua-blocker-sync.yml, the peter-evans/create-pull-request action specifies reviewers. However, in forked repositories, reviewers are not collaborators, causing the action to fail.

Since this workflow is triggered by a cron schedule, failure notifications are sent periodically. To address this, PR creation has been restricted to only the upstream repository.

Additional note: Even in the upstream repository, the specified reviewers are not collaborators, which appears to cause the same error1. Removing the reviewers field altogether could also be considered.
It seems that in the initial PRs, reviewers were assigned correctly2, so perhaps there has been a change in the GitHub API specification?

Create or update the pull request
  Attempting creation of pull request
  Created pull request #1526 (honojs:chore/sync-robots-json => main)
  Applying labels 'robots.json'
  Applying assignees 'finxol'
  Requesting reviewers 'finxol'
  Error: Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the honojs/middleware repository. - https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

Footnotes

  1. https://github.com/honojs/middleware/actions/runs/18796556639/job/53637301727

  2. https://github.com/honojs/middleware/pull/1229

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2025

⚠️ No Changeset found

Latest commit: 43ddbf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yusukebe
Copy link
Member

@3w36zj6

Ah, I see! We should fix it.

Hey @BarryThePenguin Is the setting of this PR good?

@BarryThePenguin
Copy link
Contributor

I'd probably just disable the entire workflow in forks with

jobs:
  sync-and-pr:
    if: ${{ github.event.repository.fork == false }}

@3w36zj6 3w36zj6 force-pushed the feature/restict-pr-creation-to-only-upstream-repository-in-ci branch from 8b345c0 to 43ddbf2 Compare November 4, 2025 21:41
Copy link
Contributor

@BarryThePenguin BarryThePenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

I'm guessing we'll have to wait for the next Cron to trigger to make sure it works 😅

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Nov 5, 2025

@3w36zj6 @BarryThePenguin Thanks!

@yusukebe yusukebe merged commit add2e4c into honojs:main Nov 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants