refactor: replace tsup with tsdown #1528
Conversation
|
BarryThePenguin
force-pushed
the
refactor/replace-tsup-with-tsdown
branch
from
673718e to
1c0e973
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
==========================================
+ Coverage 83.28% 83.66% +0.37%
==========================================
Files 106 106
Lines 3417 3410 -7
Branches 876 899 +23
==========================================
+ Hits 2846 2853 +7
+ Misses 483 468 -15
- Partials 88 89 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BarryThePenguin
force-pushed
the
refactor/replace-tsup-with-tsdown
branch
8 times, most recently
from
255799c to
05cdef5
Compare
BarryThePenguin
force-pushed
the
refactor/replace-tsup-with-tsdown
branch
from
05cdef5 to
615c72e
Compare
| import { defineConfig } from 'tsdown' | ||
|
|
||
| export default defineConfig({ | ||
| attw: true, |
There was a problem hiding this comment.
Ohh, tsdown includes the arethetypeswrong and publint?? It's cool!
There was a problem hiding this comment.
Can all tsdown.config.tss in the packages look for tsdown.config.ts in the top, and can we remove the tsdown.config.ts`s?
There was a problem hiding this comment.
Yes, that would be good except
@hono/zod-openapihaving a dependency on@hono/zod-validator, as CI needs to build@hono/zod-validatorbefore building@hono/zod-openapi- Each workspace has slightly different config, eg
entry,attw.profile, etc..
I'll do my best to remove any duplicate configuration, but I think we'll still need to include most of them
2 participants
It looks like
tsupis no longer actively maintained, and they're recommending people migrate totsdowninstead