feat: allow async beforeNotify functions to modify the notice object

[KonnorRogers]

Status

READY

Description

Fixes #981.
Allow async beforeNotify handlers to modify the notice object before sending to Honeybadger.

Todos

• async beforeNotifyHandler
• async afterNotifyHandler
• Tests (fix integration tests)
• Documentation

[BethanyBerkowitz]

Not trying to gum up progress here, but I don't feel great about how the return value of notify() is working in this PR.. let's discuss further?

[BethanyBerkowitz]

The documentation helps, thanks. I still think it's not ideal, but I understand wanting to keep backwards-compatibility!

[subzero10]

I will go ahead and merge this to get this feature out, but here's what I'm thinking:

• we could ditch the return value of the notify() function entirely
• knowing that one can get this information by setting an afterNotify handler (if a notice is not going to be sent, an afterNotify handler will be called with the notice and an error)
• this should probably be a major version bump

What do you think?

[joshuap]

• we could ditch the return value entirely

How would a user programmatically stop a notice from being sent?

[subzero10]

• we could ditch the return value entirely

How would a user programmatically stop a notice from being sent?

I am referring to the return value of the notify() function, not the beforeNotify handlers. Does this make sense?
(I edited my comment above to make it more clear)

[joshuap]

• we could ditch the return value entirely

How would a user programmatically stop a notice from being sent?

I am referring to the return value of the notify() function, not the beforeNotify handlers. Does this make sense? (I edited my comment above to make it more clear)

Gotcha—yeah, I think that makes sense.

[subzero10]

Gotcha—yeah, I think that makes sense.

Done! See #1162.
cc @BethanyBerkowitz