feat: chrome extension build #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #1383
subzero10
commented
Aug 19, 2024
There was a problem hiding this comment.
No code change here, just moved to its own file.
packages/js/src/browser.ts
Outdated
|
|
||
| private getUserFeedbackSubmitUrl() { | ||
| return getUserFeedbackScriptUrl(this.getVersion()) | ||
| const form = new BrowserFeedbackForm(this.config, this.logger, this.getVersion()); |
There was a problem hiding this comment.
I moved feedback form code to its own file to reduce chances of breaking the code removal by rearranging methods.
There was a problem hiding this comment.
This refactor broke the integration tests. I am working on fixing them.
stympy
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Creates a new chrome extension build that excludes the "Collect User Feedback Form" feature that would cause chrome extensions to be rejected.
The excluded code is isolated in a file
feedback-form.tsand the removal is done usingrollup-plugin-strip-code.The additional build file is
honeybadger.ext.min.jsand is also uploaded on CDN.Closes: #1383
Todos
honeybadger.ext.min.js