Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make project-id redundant for check-ins configuration api #1274

Merged
merged 5 commits into from
Dec 28, 2023
Merged

feat: make project-id redundant for check-ins configuration api #1274

merged 5 commits into from
Dec 28, 2023

Conversation

subzero10
Copy link
Member

@subzero10 subzero10 commented Dec 27, 2023 •
edited
Loading

Status

Ready

Description

Closes #1263.

Todos

  • Make name optional.
  • Make slug a required field.
  • Remove the project_id field from check-ins.
  • Assume all check-ins in a configuration file belong to the project_id that maps to the project API key.
  • Use slug to check-in instead of name
  • Update documentation to reflect the changes above.

@subzero10 subzero10 self-assigned this Dec 27, 2023
@subzero10 subzero10 requested review from stympy and removed request for stympy December 27, 2023 16:05
@subzero10 subzero10 requested a review from stympy December 28, 2023 06:17
@subzero10 subzero10 merged commit 4ffe44a into master Dec 28, 2023
9 checks passed
@subzero10 subzero10 deleted the check-ins-improvements-#1263 branch December 28, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stympy stympy stympy approved these changes

Assignees

@subzero10 subzero10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check-Ins configuration API improvements
2 participants
@subzero10 @stympy