Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace cosmiconfig with custom implementation #1268

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

subzero10
Copy link
Member

@subzero10 subzero10 commented Dec 23, 2023

Status

READY

Description

Fixes: #1264
Replaces cosmiconfig with a simpler implementation.

Todos

@subzero10 subzero10 added the js @honeybadger-io/js label Dec 23, 2023
@subzero10 subzero10 self-assigned this Dec 23, 2023
@subzero10 subzero10 requested a review from stympy December 23, 2023 07:24
@subzero10
Copy link
Member Author

Integration tests are failing. I will rebase once #1270 is merged.

stympy
stympy previously approved these changes Dec 23, 2023
@subzero10 subzero10 force-pushed the remove-cosmiconfig-2-#1264 branch from 6a04263 to a93c97f Compare December 27, 2023 07:53
@subzero10 subzero10 merged commit c2e1c3d into master Dec 27, 2023
9 checks passed
@subzero10 subzero10 deleted the remove-cosmiconfig-2-#1264 branch December 27, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
js @honeybadger-io/js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typescript.js included in esbuild output through cosmiconfig
2 participants