-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check-ins configuration api #1241
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cbcae61
feat: check-ins configuration api
subzero10 4660140
chore: fix tests
subzero10 9bcf5b7
chore: js client checkin using name
subzero10 c03194e
chore: catch errors from checkins client
subzero10 0ae46ef
chore: read config from file
subzero10 15dfa7c
chore: ci fixes
subzero10 a76c985
chore: fix requests
subzero10 494c309
chore: improved error message
subzero10 051649b
chore: default values should be empty strings
subzero10 eb2d00f
chore: default values should be empty strings
subzero10 4aec048
chore: wip
subzero10 4073ae4
chore: update lock files
subzero10 746efd2
Revert "chore: update lock files"
subzero10 45a2a8b
chore: remove mock fs
subzero10 34e39af
chore: add test
subzero10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import { Client as BaseClient } from '../src/client' | ||
import { Config, Logger, Notice, Noticeable, Transport, TransportOptions, NoticeTransportPayload, UserFeedbackFormOptions } from '../src/types' | ||
import { Config, Logger, Notice, Noticeable, Transport, TransportOptions, UserFeedbackFormOptions } from '../src/types' | ||
|
||
export function nullLogger(): Logger { | ||
return { | ||
|
@@ -12,7 +12,10 @@ export function nullLogger(): Logger { | |
} | ||
|
||
export class TestTransport implements Transport { | ||
send(_options: TransportOptions, _payload: NoticeTransportPayload): Promise<{ statusCode: number; body: string }> { | ||
defaultHeaders(): Record<string, string> { | ||
return {}; | ||
} | ||
send<T>(_options: TransportOptions, _payload: T): Promise<{ statusCode: number; body: string }> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Made the |
||
return Promise.resolve({ body: JSON.stringify({ id: 'uuid' }), statusCode: 201 }); | ||
} | ||
} | ||
|
20 changes: 20 additions & 0 deletions
20
packages/js/examples/checkins-manager/honeybadger.config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
module.exports = { | ||
personalAuthToken: process.env.HONEYBADGER_PERSONAL_AUTH_TOKEN, | ||
checkins: [ | ||
{ | ||
name: 'Weekly Exports', | ||
slug: 'weekly-exports-custom-slug', | ||
projectId: process.env.HONEYBADGER_PROJECT_ID, | ||
scheduleType: 'simple', | ||
reportPeriod: '1 week', | ||
gracePeriod: '10 minutes' | ||
}, | ||
{ | ||
name: 'Hourly Notifications', | ||
projectId: process.env.HONEYBADGER_PROJECT_ID, | ||
scheduleType: 'simple', | ||
reportPeriod: '1 hour', | ||
gracePeriod: '5 minutes' | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import Honeybadger from '@honeybadger-io/js' | ||
|
||
console.log('Hello from checkins-manager') | ||
console.log(Honeybadger.config) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"name": "checkins-manager", | ||
"version": "1.0.0", | ||
"description": "an example that demonstrates checkins configuration api", | ||
"main": "index.mjs", | ||
"scripts": { | ||
"start": "node index.mjs", | ||
"test": "echo \"Error: no test specified\" && exit 1" | ||
}, | ||
"dependencies": { | ||
"@honeybadger-io/js": "file:../.." | ||
}, | ||
"author": "", | ||
"license": "ISC" | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support more than one client (
CheckinsClient
andHoneybadgerClient
)