refactor(c901): fix UAT harness (4 files) below C901 threshold, remove from grandfather list#1955
Conversation
|
@codex review — apply the review criteria in .gemini/styleguide.md in addition to AGENTS.md guidance |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
859b48d to
a1ee347
Compare
…ther list Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DxGQhYBQg7681uCdr9w9qB
e17f277 to
030cb70
Compare
|
@codex review — apply the review criteria in .gemini/styleguide.md in addition to AGENTS.md guidance |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
What does this PR do?
Fixes the 4 UAT-harness files from the C901 (McCabe complexity) grandfather list tracked in issue #925, by extracting private helper functions with no behavior change:
tests/uat/ha_wait.py:wait_for_ha_ready(12)tests/uat/openai_agent.py:tool_call_loop(18)tests/uat/run_uat.py:run_cli(17),run(17),run_agent_scenario(14),make_phase_summary(11)tests/uat/stories/run_story.py:run_stories(27),_run_test_prompt(14),append_result(14),_extract_tool_sequence(13)Removes all 4 from
pyproject.toml's C901 per-file-ignore list.Stacked on #1953 (which stacks on #1940) to keep the shared grandfather-list edits conflict-free; base retargets to master as its parents merge.
No docstring, CLI-argument, or string-literal change: an AST-level comparison of before/after confirms docstrings, signatures, and every pre-existing string literal (prompts, report text, CLI help) are byte-identical; the only additions are private
_helperfunctions carrying relocated logic.Type of change
Testing
I have tested these changes with a LLM agent
All automated tests pass (
uv run pytest)Code follows style guidelines (
uv run ruff check)ruff checkrepo-wide with the 4 per-file ignores removed (C901 live): all checks passruff format --check: cleanpython -m py_compileon all 4 files: cleanThe UAT harness has no automated test coverage by design (it drives live LLM agents); verification is lint + compile + AST-level identity of all pre-existing defs and strings
Checklist