Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CPU IDs for GRUB lagacy boot - Fix for #3692 #3790

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
+13 −3
Open

Added CPU IDs for GRUB lagacy boot - Fix for #3692 #3790

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4568b7
fix for #3692
MYF540 Jan 11, 2025
66d5e56
Update buildroot-external/patches/grub2/0002-loader-efi-linux-use-leg…
MYF540 Jan 11, 2025
745cb2f
Update 0002-loader-efi-linux-use-legacy-loader-for-broken-Intel-.patch
MYF540 Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ...ot-external/patches/grub2/0002-loader-efi-linux-use-legacy-loader-for-broken-Intel-.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ pre-2.12 GRUB anyway.
[4] https://github.com/home-assistant/operating-system/issues/3305#issuecomment-2360633688

Signed-off-by: Jan Čermák <[email protected]>

----

Just added exceptions for Ryzen 5 2400GE, AMD Ryzen Embedded R1505G and AMD G-T56N as mentioned in [5].

[5] https://github.com/home-assistant/operating-system/issues/3692

---
grub-core/loader/efi/linux.c | 67 +++++++++++++++++++++++++++++++++++-
1 file changed, 66 insertions(+), 1 deletion(-)
Expand Down Expand Up @@ -105,9 +112,12 @@ index bfbd95a..98ac99c 100644
+ * false positives instead).
+ */
+ return (processor_id == 0xbfebfbff00030661 // D2xxx/N2xxx
+ || processor_id == 0xbfebfbff000106ca // D525
+ || processor_id == 0x00730f01178bfbff // AMD GX-212JC (HP t520)
+ || processor_id == 0xbfebfbff000206a7); // Intel i5-2xxx (Macbook Air A1370)
+ || processor_id == 0xbfebfbff000106ca // D525
+ || processor_id == 0x00730f01178bfbff // AMD GX-212JC (HP t520)
+ || processor_id == 0xbfebfbff000206a7 // Intel i5-2xxx (Macbook Air A1370)
+ || processor_id == 0x178bfbff00730f00 // AMD Ryzen 5 2400GE
+ || processor_id == 0x178bfbff00730f81 // AMD Ryzen Embedded R1505G
+ || processor_id == 0x500f01007ffffff); // AMD G-T56N
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure with this one, HP T610 was reported working fine with OS 13.0 which already included the new GRUB, yet it also contained a revert of another patch that served as an initial attempt to fix the boot issues with EFI loader. See here: #3395 (comment)

Copy link
Author

@MYF540 MYF540 Jan 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sorry, I tried to adopt your patch, but I am a bloody rookie.

I can't say any more about the HP T610. A user (@SellSan) commented on it in my bug report (#3692 (comment)) and I just added it blindly. This is also the case for the Ryzen R1505G btw (#3305 (comment)).

+ }
+ else
+ {
Expand Down