-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Z3FOLD option from Tinker kernel config #3755
Conversation
The z3fold allocator was deprecated with the reasoning explained in [1] and this patch was backported to stable 6.6.y as well. We enable zsmalloc in shared hassos.config and the enabled option in the Tinker config was probably just some remnant from the past. [1] https://lore.kernel.org/linux-mm/[email protected]/
📝 WalkthroughWalkthroughThe pull request involves a modification to the kernel configuration file for the Asus Tinker board. The primary change is the removal of the Changes
Rationale for ChangeWhile the raw summary doesn't explicitly state the reason for removing the Z3FOLD configuration, the change indicates a deliberate decision to modify the kernel's memory compression strategy. Z3FOLD is an alternative memory compression mechanism, and its removal might be related to performance optimization, compatibility issues, or a preference for alternative memory management techniques. The configuration file continues to maintain a comprehensive set of kernel features, suggesting that this change is a targeted modification rather than a wholesale restructuring of the kernel configuration. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The z3fold allocator was deprecated with the reasoning explained in [1] and this patch was backported to stable 6.6.y as well. We enable zsmalloc in shared hassos.config and the enabled option in the Tinker config was probably just some remnant from the past.
[1] https://lore.kernel.org/linux-mm/[email protected]/
Summary by CodeRabbit
Bug Fixes
New Features