Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unapplied BRCM_TRACING option from Rockchip kernel config #3754

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

sairon
Copy link
Member

@sairon sairon commented Dec 19, 2024

The Rockchip config contained BRCM_TRACING option which had no effect without TRACING enabled. The option now depends on that option since [1], resulting in warning in our config checker.

[1] https://lore.kernel.org/lkml/81a29b15eaacc1ac1fb421bdace9ac0c3385f40f.1727179742.git.geert@linux-m68k.org/

Summary by CodeRabbit

  • New Features

    • Enhanced kernel configuration for improved resource management and scheduling.
    • Enabled support for a wider range of networking capabilities and USB devices.
    • Added configurations for various sensor and input devices, as well as audio subsystem support.
  • Bug Fixes

    • Updated configuration options to ensure proper functionality of certain features.

The Rockchip config contained BRCM_TRACING option which had no effect without
TRACING enabled. The option now depends on that option since [1], resulting in
warning in our config checker.

[1] https://lore.kernel.org/lkml/81a29b15eaacc1ac1fb421bdace9ac0c3385f40f.1727179742.git.geert@linux-m68k.org/
@sairon sairon added board/odroid Hardkernel's ODROID Boards linux Linux kernel related issue board/green Home Assistant Green labels Dec 19, 2024
@sairon sairon requested a review from agners December 19, 2024 12:27
Copy link

coderabbitai bot commented Dec 19, 2024

📝 Walkthrough

Walkthrough

The pull request introduces configuration changes to the kernel configuration file for ARM64 Rockchip platforms. The modifications focus on enabling and configuring various kernel features, including BPF syscalls, cgroup management, networking capabilities, USB support, sensor interfaces, and audio subsystems. The changes aim to enhance the kernel's functionality and hardware support by selectively enabling or disabling specific kernel configurations.

Changes

File Change Summary
buildroot-external/kernel/v6.6.y/kernel-arm64-rockchip.config - Enabled BPF syscalls and JIT compilation
- Configured cgroup options
- Enabled 48-bit virtual address space
- Enhanced networking configurations
- Expanded USB device support
- Added sensor and input device configurations
- Improved audio subsystem support
- Disabled CONFIG_BRCM_TRACING

Sequence Diagram

sequenceDiagram
    participant Kernel
    participant BPF
    participant Networking
    participant USB
    participant Sensors
    participant Audio

    Kernel->>BPF: Enable Syscalls
    Kernel->>Networking: Configure Network Protocols
    Kernel->>USB: Enable Device Support
    Kernel->>Sensors: Add Input Configurations
    Kernel->>Audio: Configure Sound Subsystem
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52774c4 and 2c44851.

📒 Files selected for processing (1)
  • buildroot-external/kernel/v6.6.y/kernel-arm64-rockchip.config (0 hunks)
💤 Files with no reviewable changes (1)
  • buildroot-external/kernel/v6.6.y/kernel-arm64-rockchip.config

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sairon sairon merged commit b02eee1 into dev Dec 19, 2024
3 checks passed
@sairon sairon deleted the remove-unused-brcm-tracing-option branch December 19, 2024 12:59
@sairon sairon mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board/green Home Assistant Green board/odroid Hardkernel's ODROID Boards cla-signed linux Linux kernel related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants