Improve wired/wireless NICs support #2761

FlyGoat · 2023-09-21T10:16:30Z

Hi,

This PR enabled various USB/PCIe wired/wireless NICs in Kconifg and their firmware in buildroot config, so there will be no suprise on ethernet support for OS users.

All configs are derivived from debian's kernel config: https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/config/config

Please review, thanks!

Signed-off-by: Jiaxun Yang <[email protected]>

Derivived from: https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/config/config https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/config/amd64/config Signed-off-by: Jiaxun Yang <[email protected]>

Signed-off-by: Jiaxun Yang <[email protected]>

home-assistant · 2023-09-21T10:16:33Z

Hi @FlyGoat

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

agners

In general, in Home Assistant OS we so far have been enabling drivers on a as-needed basis. I am not against bulk enabling drivers, where it make sense. But we should avoid unnecessary kernel bloat to keep things clean as much as possible.

agners · 2023-09-21T10:37:03Z

buildroot-external/board/pc/ova/kernel.config

-CONFIG_IWLMVM=m
-
-CONFIG_WLAN_VENDOR_REALTEK=y
-CONFIG_RTL_CARDS=m


This is also required by some USB adapters, so I think this and the above should stay in here.

@agners I think OVA included device-support.config as well? Those are moved to device-support.config.

agners · 2023-09-21T10:38:29Z

buildroot-external/board/pc/ova/kernel.config

-CONFIG_RTL_CARDS=m
-CONFIG_RTL8723BE=y
-
-CONFIG_BCMA=m


I think this driver can be used on non PCIe targets as well. Not sure if that is actually the case though.

buildroot-external/board/pc/generic-x86-64/kernel.config

agners · 2023-09-21T10:42:49Z

buildroot-external/kernel/device-support.config

 CONFIG_BT_HCIBTUSB=m
+CONFIG_BT_HCIBTUSB_AUTOSUSPEND=y


Are you sure that this doesn't lead to problems?

Debian is doing that for years, if it doesn't sound right I'll just remove this :-)

FlyGoat · 2023-09-21T14:28:20Z

In general, in Home Assistant OS we so far have been enabling drivers on a as-needed basis. I am not against bulk enabling drivers, where it make sense. But we should avoid unnecessary kernel bloat to keep things clean as much as possible.

I was a little bit frustrated finding that either BCM4356 on my BarTrail mini-PC and a MediaTek USB wireless adaptar won't work with HAOS, so I spent my time on align HAOS NIC support with other Linux distros.

I think NIC, as are essential device for HAOS to work, shouldn't give user any suprise on driver issues. After bulk enabling NIC drivers HAOS can reassure users like "if your ethernet card works on other distros, it will work for us as well".

FlyGoat · 2023-09-21T14:40:54Z

Hmm, ouch I just notified that I'm enabling some extra drivers that is not in kernel 6.1 yet.
What do you perfer me to do with those configs? Leave them there for easier kernel upgrade in future or document them else where?

agners · 2023-09-21T15:07:49Z

Leave them there for easier kernel upgrade in future or document them else where?

I'd prefer if you could list those elsewhere, so we can add them on next kernel update.

patryk4815 · 2023-09-28T05:48:34Z

related: #2776

Please, copy all firmware files for mediatek.

agners · 2023-10-03T13:53:09Z

I've created two builds to check the impact of this change:

The kernel image size got about 500KiB smaller (from 14803808 bytes to 14803808 bytes, presumably because some drivers changed from built-in to modules).

The compressed size of the rootfs squashfs changed from 228MB to 246MB, so a growth of 18MB. The rootfs partition where the rootfs squashfs is stored is 256MB (for A slot as well as B slot). Without re-partitioning we cannot grow beyond that.

That means we have less than 10MB spare after this change, which is really making me a bit uncomfortable. 😰

patryk4815 · 2023-10-03T16:48:50Z

@agners You can enable CONFIG_MODULE_COMPRESS and it will compress modules ;)

Right now it is disabled in HAOS:

# zcat /proc/config.gz | grep 'CONFIG_MODULE_COMPRESS'
CONFIG_MODULE_COMPRESS_NONE=y
# CONFIG_MODULE_COMPRESS_GZIP is not set
# CONFIG_MODULE_COMPRESS_XZ is not set
# CONFIG_MODULE_COMPRESS_ZSTD is not set

agners · 2023-10-03T19:55:59Z

@agners You can enable CONFIG_MODULE_COMPRESS and it will compress modules ;)

That doesn't help much as the whole squashfs based rootfs is compressed already.

agners · 2023-10-03T13:56:26Z

buildroot-external/board/pc/generic-x86-64/kernel.config

+CONFIG_DUMMY=m
+CONFIG_NET_FC=y
+CONFIG_NET_SB1000=m
+CONFIG_VMXNET3=m


This driver is used on VMs only and already enabled in the ova kernel config.

Suggested change

CONFIG_VMXNET3=m

agners · 2023-10-03T13:57:53Z

buildroot-external/board/pc/generic-x86-64/kernel.config

+CONFIG_PCI_HYPERV=y
+


Same as above.

Suggested change

CONFIG_PCI_HYPERV=y

agners · 2023-10-04T09:23:55Z

buildroot-external/configs/generic_x86_64_defconfig

 BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_22000=y
 BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_22260=y
 BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3160=y
 BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3168=y
-BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3945=y
-BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_4965=y


What is the reason for removing those?

agners · 2023-10-04T09:26:25Z

We should split up this PR a bit. The wired NIC support probably doesn't add as much as there is no additional firmware required typically. I am inclined to merge such a change, even when it enables things in bulk.

However, on the wireless end we might need to filter out a bit more what is actively used.

FlyGoat · 2023-10-04T10:22:26Z

We should split up this PR a bit. The wired NIC support probably doesn't add as much as there is no additional firmware required typically. I am inclined to merge such a change, even when it enables things in bulk.

However, on the wireless end we might need to filter out a bit more what is actively used.

Yes that was something I'm trying to investigate in past weeks. The problem is, 6.1 LTS doesn't support some of very popular wireless NICs especially 11ax one. I was messing around linux-backport with buildroot bit that's probably too much hassle.

agners · 2023-10-04T11:57:15Z

Yes that was something I'm trying to investigate in past weeks. The problem is, 6.1 LTS doesn't support some of very popular wireless NICs especially 11ax one. I was messing around linux-backport with buildroot bit that's probably too much hassle.

While I prefer to use the LTS versions of the kernel, we did use non-LTS in the past for particular boards to get the latest versions of certain drivers. So before doing to much work on backports etc, probably moving to a regular stable kernel is the better approach.

That said, this should be the third step 😄 Enabling what is available on 6.1 should be first.

FYI, we intend to release a first 11.0.rc1 probably tomorrow.

Preemptively enable larger set of WiFi drivers for all platforms and add more firmwares for them with the aim to harmonize WiFi device support among all boards and to have implicit support of devices that users might want to use. Targets `generic_aarch64`, `generic_x86_64` and `ova` also include options and firmwares for cards that are using PCI/PCIe bus - support for these is in a separate config fragment. Especially the `generic_x86_64` is currently very tight with the rootfs space, so I had to do some triaging and select only sensible drivers and firmwares - especially archaic PCMCIA devices or devices not supporting only 802.11g or lower standards were among the first that I removed during the triaging - we can consider enabling those but this time on an someone's explicit need to have them enabled. This closes #2815 and replaces large part of #2761, also potentially addresses (at least) these: #2806, #2783, #2841, #2776, #2725, #2600 ------------- * Remove WiFi options from generic and board kernel config fragments * Enable MMC in OVA kernel This is needed for SDIO drivers to work. Use the same options as we currently use for generic_x86_64. * Add CRYPTO_MICHAEL_MIC to the common kernel config This is requirement for TKIP and is a dependency of ATH11K driver. * Add kernel config fragments with wireless cards support * Add firmwares for WiFi cards * Enable more Bluetooth device drivers

agners · 2023-12-21T15:11:44Z

Most of the aim of this PR has been addressed by the PR's linked. HAOS 11.3 will support many more WiFi devices as well as a couple more USB/PCIe network devices. If anything is still missing, please feel free to send a PR and enable the driver as required.

FlyGoat added 6 commits September 15, 2023 11:40

Move all pcie ethernet drivers to device-support-pcie.config

dc3adee

Signed-off-by: Jiaxun Yang <[email protected]>

Enable extra PCI NICs

b3b7507

Derivived from: https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/config/config https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/config/amd64/config Signed-off-by: Jiaxun Yang <[email protected]>

Enable extra USB/UART/SDIO BT HCI

2c21718

Signed-off-by: Jiaxun Yang <[email protected]>

Enable extra USB NICs

71ab1ec

Signed-off-by: Jiaxun Yang <[email protected]>

Enable extra wireless cards

b05363a

Signed-off-by: Jiaxun Yang <[email protected]>

Enable extra firmwares

a3e2285

Signed-off-by: Jiaxun Yang <[email protected]>

home-assistant bot added the cla-needed label Sep 21, 2023

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Sep 21, 2023

agners reviewed Sep 21, 2023

View reviewed changes

agners reviewed Oct 4, 2023

View reviewed changes

agners mentioned this pull request Oct 9, 2023

Support for AW-CM389MA #2783

Closed

anatoly-savchenkov mentioned this pull request Oct 12, 2023

WiFi dongle based on Mediatek mt7921au chipset #2806

Closed

agners mentioned this pull request Oct 17, 2023

generic-x86-64: Add support for AW-CM389MA #2815

Closed

sairon mentioned this pull request Nov 29, 2023

Enable more WiFi drivers for all platforms #2951

Merged

agners closed this Dec 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve wired/wireless NICs support #2761

Improve wired/wireless NICs support #2761

FlyGoat commented Sep 21, 2023

home-assistant bot commented Sep 21, 2023

agners left a comment

agners Sep 21, 2023

FlyGoat Sep 21, 2023

agners Sep 21, 2023

agners Sep 21, 2023

FlyGoat Sep 21, 2023

FlyGoat commented Sep 21, 2023

FlyGoat commented Sep 21, 2023

agners commented Sep 21, 2023

patryk4815 commented Sep 28, 2023 •

edited

Loading

agners commented Oct 3, 2023

patryk4815 commented Oct 3, 2023

agners commented Oct 3, 2023

agners Oct 3, 2023

agners Oct 3, 2023

agners Oct 4, 2023

agners commented Oct 4, 2023

FlyGoat commented Oct 4, 2023

agners commented Oct 4, 2023

agners commented Dec 21, 2023

		CONFIG_BT_HCIBTUSB=m
		CONFIG_BT_HCIBTUSB_AUTOSUSPEND=y

Improve wired/wireless NICs support #2761

Improve wired/wireless NICs support #2761

Conversation

FlyGoat commented Sep 21, 2023

home-assistant bot commented Sep 21, 2023

agners left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FlyGoat commented Sep 21, 2023

FlyGoat commented Sep 21, 2023

agners commented Sep 21, 2023

patryk4815 commented Sep 28, 2023 • edited Loading

agners commented Oct 3, 2023

patryk4815 commented Oct 3, 2023

agners commented Oct 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agners commented Oct 4, 2023

FlyGoat commented Oct 4, 2023

agners commented Oct 4, 2023

agners commented Dec 21, 2023

patryk4815 commented Sep 28, 2023 •

edited

Loading