Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SV] Added binary_sensor_HassGetState.yaml + "som" as skip word #2841

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

slungs
Copy link
Contributor

@slungs slungs commented Jan 6, 2025

No description provided.

domain: binary_sensor
device_class: battery
state: "on"
response: "Inte någon"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how "genetiv" should be handled here. Could we do some logic within the scope of the which response?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would be possible to have 2 version of the "which" respond depending to sentence.
It might also be that the "which" respond should be simplifyed to "Ingen/Inget"

@slungs
Copy link
Contributor Author

slungs commented Jan 7, 2025

The test is failing for code I have not touched in this pr. It is skipped when run locally.

@larsdunemark
Copy link
Contributor

@slungs I think the problem could be that we added "som" as skip word and it is part of the testcase for timers. "som heter ...."

@slungs
Copy link
Contributor Author

slungs commented Jan 8, 2025

@slungs I think the problem could be that we added "som" as skip word and it is part of the testcase for timers. "som heter ...."

Yeah you are right. I removed it again and will add it back in another PR if used. I think I got it right now.

domain: binary_sensor
device_class: battery
state: "on"
response: "Inte någon"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would be possible to have 2 version of the "which" respond depending to sentence.
It might also be that the "which" respond should be simplifyed to "Ingen/Inget"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants