[EN] Add floor support to HassClimateGetTemperature #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwilsdon
requested review from
mrdarrengriffin,
tetele and
ViViDboarder
as code owners
tetele
approved these changes
Dec 27, 2024
ViViDboarder
requested changes
Dec 27, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
jackwilsdon
force-pushed
the
climate-get-current-area
branch
4 times, most recently
from
00c4980 to
b887e91
Compare
ViViDboarder
requested changes
Dec 27, 2024
ViViDboarder
approved these changes
Dec 27, 2024
19 tasks
|
Just opened home-assistant/core#134098 which adds floor support to core 👍 |
|
Maybe split out the part about floor support, so we can get this merged with area support now. |
jackwilsdon
changed the title
|
Split out area support into #2793 👍 |
|
#2793 is merged, you need to rebase this PR now to solve the conflict. |
jackwilsdon
force-pushed
the
climate-get-current-area
branch
from
84b984f to
f137fd4
Compare
jackwilsdon
changed the title
jackwilsdon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
English equivalent of #2788. Fixes home-assistant/core#133733.
I removed
is it (hot|cold|warm|cool) [in <area>], as it didn't seem to work and doesn't really make much sense considering the response ("N degrees"). Happy to add it back (and fix it) if it's still wanted.