[En] remove the from <light>
#2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetele
requested changes
Dec 13, 2024
ViViDboarder
force-pushed
the
en-remove-the-from-light
branch
3 times, most recently
from
962a689 to
114e41a
Compare
ViViDboarder
force-pushed
the
en-remove-the-from-light
branch
from
114e41a to
36a8158
Compare
This doesn't always make sense in a sentence to allow `the` to prefix. It's not that big of a deal, however once adding `<the>` in, it does increase the number of matching sentences by even more. This patch can be considered an optimization rather than a quality improvement.
ViViDboarder
force-pushed
the
en-remove-the-from-light
branch
from
a309d96 to
7c8cb25
Compare
|
Rebased anyway to make the commit history cleaner. |
mrdarrengriffin
approved these changes
Jan 7, 2025
mrdarrengriffin
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't always make sense in a sentence to allow
theto prefix. It's notthat big of a deal, however once adding
<the>in, it does increase the numberof matching sentences by even more. This patch can be considered an optimization
rather than a quality improvement.
Based on top of #2727