[FR] Enhanced some wordings into french sentences #2707
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Hi @RSickenberg
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml Update sentences/fr/binary_sensor_HassGetState.yaml
RSickenberg
force-pushed
the
french-fix-rsickenberg-patch1
branch
from
cec82e2 to
2cf91de
Compare
|
All good, sorry for the noise. |
sentences/fr/_common.yaml
Outdated
| @@ -682,7 +682,7 @@ expansion_rules: | |||
| # Mets | |||
| mets_dirty: "(mais|maître)" | |||
| # ferme | |||
| ferme_dirty: "faire" | |||
| ferme_dirty: "(faire|fêrme)" | |||
There was a problem hiding this comment.
Does a specific STT engine provide that word? It's not a french word, right?
There was a problem hiding this comment.
In French, it's a "Farm" but without the ^ on the e, I am technically not sure which one could be an error in an STT engine. I can fix it or remove it.
|
PR needs to be rebased as battery intents have been removed. |
|
Ci is failing because of missing test for the new sentence |
piitaya
dismissed stale reviews from home-assistant[bot] and themself
cla signed
|
@RSickenberg What is the state of this PR? Thx a lot! JLo |
|
@jlpouffier I don't have time to write tests. Feel free to close it or just update the test. :) Edit: Changed statement about knowledge b.c I can learn. It's just an amount of time. Best, |
No description provided.