Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HassClimateGetTemperature does not use area of assistant #133733

Closed
jackwilsdon opened this issue Dec 21, 2024 · 3 comments · Fixed by home-assistant/intents#2793 · May be fixed by home-assistant/intents#2790
Closed

HassClimateGetTemperature does not use area of assistant #133733

jackwilsdon opened this issue Dec 21, 2024 · 3 comments · Fixed by home-assistant/intents#2793 · May be fixed by home-assistant/intents#2790
Assignees
@synesthesiam
Labels
integration: conversation

Comments

@jackwilsdon
Copy link
Contributor

jackwilsdon commented Dec 21, 2024 •
edited
Loading

The problem

Asking "what's the temperature" on a Voice PE returns the temperature of what seems to be the first exposed climate entity, instead of the entity exposed in the same area as the assistant.

I have the following entities exposed:

  • climate.hall
  • climate.kitchen
  • climate.living_room

The Voice PE is located in the living room and the areas are set correctly on all of the climate entities, but asking for the temperature returns the temperature from climate.hall. Un-exposing climate.hall causes it to return the temperature of climate.kitchen, and so on.

Asking "what's the temperature in the living room" works as expected, it's just when an area is omitted that it uses the wrong entity.

What version of Home Assistant Core has the issue?

core-2024.12.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

Assistant debug information:

stage: done
run:
  pipeline: 01hjsafjatqb7n37tpj8r6n7m8
  language: en
events:
  - type: run-start
    data:
      pipeline: 01hjsafjatqb7n37tpj8r6n7m8
      language: en
    timestamp: "2024-12-21T15:20:42.908050+00:00"
  - type: stt-start
    data:
      engine: stt.home_assistant_cloud
      metadata:
        language: en-GB
        format: wav
        codec: pcm
        bit_rate: 16
        sample_rate: 16000
        channel: 1
    timestamp: "2024-12-21T15:20:42.908391+00:00"
  - type: stt-vad-start
    data:
      timestamp: 860
    timestamp: "2024-12-21T15:20:43.750908+00:00"
  - type: stt-vad-end
    data:
      timestamp: 2220
    timestamp: "2024-12-21T15:20:45.077508+00:00"
  - type: stt-end
    data:
      stt_output:
        text: What's the temperature?
    timestamp: "2024-12-21T15:20:45.151653+00:00"
  - type: intent-start
    data:
      engine: conversation.home_assistant
      language: en
      intent_input: What's the temperature?
      conversation_id: null
      device_id: 18d4ab8b81967d96fddab9f9d741675b
      prefer_local_intents: false
    timestamp: "2024-12-21T15:20:45.152186+00:00"
  - type: intent-end
    data:
      processed_locally: true
      intent_output:
        response:
          speech:
            plain:
              speech: 19.6 degrees
              extra_data: null
          card: {}
          language: en
          response_type: query_answer
          data:
            targets: []
            success: []
            failed: []
        conversation_id: null
    timestamp: "2024-12-21T15:20:45.170302+00:00"
  - type: tts-start
    data:
      engine: tts.home_assistant_cloud
      language: en-GB
      voice: LibbyNeural
      tts_input: 19.6 degrees
    timestamp: "2024-12-21T15:20:45.170783+00:00"
  - type: tts-end
    data:
      tts_output:
        media_id: >-
          media-source://tts/tts.home_assistant_cloud?message=19.6+degrees&language=en-GB&tts_options=%7B%22voice%22:%22LibbyNeural%22,%22preferred_format%22:%22flac%22,%22preferred_sample_rate%22:48000,%22preferred_sample_channels%22:1,%22preferred_sample_bytes%22:2%7D
        url: /api/tts_proxy/pbPs9ypjv0NXW31NOTNoMg.flac
        mime_type: audio/flac
    timestamp: "2024-12-21T15:20:45.172473+00:00"
  - type: run-end
    data: null
    timestamp: "2024-12-21T15:20:45.173393+00:00"
stt:
  engine: stt.home_assistant_cloud
  metadata:
    language: en-GB
    format: wav
    codec: pcm
    bit_rate: 16
    sample_rate: 16000
    channel: 1
  done: true
  stt_output:
    text: What's the temperature?
intent:
  engine: conversation.home_assistant
  language: en
  intent_input: What's the temperature?
  conversation_id: null
  device_id: 18d4ab8b81967d96fddab9f9d741675b
  prefer_local_intents: false
  done: true
  processed_locally: true
  intent_output:
    response:
      speech:
        plain:
          speech: 19.6 degrees
          extra_data: null
      card: {}
      language: en
      response_type: query_answer
      data:
        targets: []
        success: []
        failed: []
    conversation_id: null
tts:
  engine: tts.home_assistant_cloud
  language: en-GB
  voice: LibbyNeural
  tts_input: 19.6 degrees
  done: true
  tts_output:
    media_id: >-
      media-source://tts/tts.home_assistant_cloud?message=19.6+degrees&language=en-GB&tts_options=%7B%22voice%22:%22LibbyNeural%22,%22preferred_format%22:%22flac%22,%22preferred_sample_rate%22:48000,%22preferred_sample_channels%22:1,%22preferred_sample_bytes%22:2%7D
    url: /api/tts_proxy/pbPs9ypjv0NXW31NOTNoMg.flac
    mime_type: audio/flac
@home-assistant
Copy link

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this issue as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign conversation Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

conversation documentation
conversation source
(message by IssueLinks)

@mib1185
Copy link
Contributor

mib1185 commented Dec 23, 2024

Indeed the sentences are not area-aware

@mib1185
Copy link
Contributor

mib1185 commented Dec 26, 2024

possible solution in home-assistant/intents#2788 (needs to be adopted to other languages as well)

@mib1185 mib1185 mentioned this issue Dec 26, 2024
Merged
This was referenced Dec 27, 2024
Draft
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@synesthesiam synesthesiam

Labels
integration: conversation
Projects
None yet
Milestone
No milestone
3 participants
@jackwilsdon @synesthesiam @mib1185