Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo "Github" in Localizable.strings #3285

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

NoRi2909
Copy link
Contributor

Summary

As GitHub is a brand name, the camel-case "H" should be kept.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

Noticed this in Lokalise as a translator added a respective comment.

As GitHub is a brand name, the camel-case "H" should be kept.
Copy link
Member

@bgoncal bgoncal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! make sure this is also update in Localize

@bgoncal bgoncal enabled auto-merge (squash) December 21, 2024 11:08
@bgoncal bgoncal merged commit b8781ed into home-assistant:master Dec 21, 2024
5 checks passed
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.14%. Comparing base (6c34210) to head (d7ae9f3).
Report is 439 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3285       +/-   ##
===========================================
+ Coverage   27.54%   46.14%   +18.59%     
===========================================
  Files         311      208      -103     
  Lines       31699    12866    -18833     
===========================================
- Hits         8733     5937     -2796     
+ Misses      22966     6929    -16037     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NoRi2909
Copy link
Contributor Author

Thanks! make sure this is also update in Localize

Doesn't the merge auto-update the English string in Lokalise?

@bgoncal
Copy link
Member

bgoncal commented Dec 22, 2024

It needs to be updated in lokalise as well

@NoRi2909
Copy link
Contributor Author

But I can't edit the English string in Lokalise, only the German translation I'm working on.

When I do a PR on Core or Frontend the Merge process automatically updates the affected strings in Lokalise.
If that is not the case for the iOS app – I cannot do that …?

@bgoncal
Copy link
Member

bgoncal commented Dec 22, 2024

I'll check on Monday for you, perhaps I can make the change

@bgoncal
Copy link
Member

bgoncal commented Dec 23, 2024

Updated ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants