Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iOS drop support message #2497

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Dec 28, 2023

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from zacwest December 28, 2023 10:33
@bgoncal bgoncal self-assigned this Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 153 lines in your changes are missing coverage. Please review.

Comparison is base (63c21ad) 28.19% compared to head (6a2f810) 28.63%.
Report is 1 commits behind head on master.

Files Patch % Lines
Sources/App/Settings/NFC/iOSTagManager.swift 0.00% 28 Missing ⚠️
Sources/App/WebView/IncomingURLHandler.swift 0.00% 19 Missing ⚠️
...s/Shared/Common/SiriIntents+ConvenienceInits.swift 0.00% 10 Missing ⚠️
Sources/App/Settings/ActionConfigurator.swift 0.00% 6 Missing ⚠️
...ources/App/Settings/Eureka/SettingsButtonRow.swift 0.00% 6 Missing ⚠️
Sources/Shared/API/Models/RealmZone.swift 58.33% 5 Missing ⚠️
Sources/App/Scenes/SceneManager.swift 20.00% 4 Missing ⚠️
Sources/App/Scenes/SettingsSceneDelegate.swift 0.00% 4 Missing ⚠️
...tings/Connection/ConnectionURLViewController.swift 0.00% 4 Missing ⚠️
...es/App/Settings/SettingsDetailViewController.swift 0.00% 4 Missing ⚠️
... and 42 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2497      +/-   ##
==========================================
+ Coverage   28.19%   28.63%   +0.43%     
==========================================
  Files         286      285       -1     
  Lines       30789    30204     -585     
==========================================
- Hits         8682     8648      -34     
+ Misses      22107    21556     -551     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit 6a94c9e into master Jan 3, 2024
8 checks passed
@bgoncal bgoncal deleted the remove-drop-support-message branch January 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants