Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign thread credentials sharing #2478

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Dec 12, 2023

Summary

Screenshots

RPReplay_Final1702405177.MP4

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from zacwest December 12, 2023 18:33
@bgoncal bgoncal self-assigned this Dec 12, 2023
@bgoncal bgoncal force-pushed the thread-credentials-redesign branch from 3ae2472 to ceebbf8 Compare December 12, 2023 18:44
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (a5d07b9) 28.21% compared to head (314f20c) 28.19%.
Report is 1 commits behind head on master.

Files Patch % Lines
...dentialsSharing/ThreadCredentialsSharingView.swift 0.00% 58 Missing ⚠️
...alsSharing/ThreadCredentialsSharingViewModel.swift 54.83% 14 Missing ⚠️
Sources/Shared/Utilities/Haptics.swift 0.00% 7 Missing ⚠️
Sources/App/WebView/WebViewController.swift 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2478      +/-   ##
==========================================
- Coverage   28.21%   28.19%   -0.03%     
==========================================
  Files         285      286       +1     
  Lines       30759    30789      +30     
==========================================
+ Hits         8680     8682       +2     
- Misses      22079    22107      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zacwest zacwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the modal presentation style so the darkening background doesn't move upwards?

@bgoncal bgoncal force-pushed the thread-credentials-redesign branch from ceebbf8 to 314f20c Compare December 12, 2023 21:01
@bgoncal
Copy link
Member Author

bgoncal commented Dec 12, 2023

can you change the modal presentation style so the darkening background doesn't move upwards?

RPReplay_Final1702414850.MP4

@bgoncal bgoncal merged commit 42d68af into master Dec 13, 2023
7 checks passed
@bgoncal bgoncal deleted the thread-credentials-redesign branch December 13, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants