Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test testComplicationsWithPreRendered #2472

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Dec 6, 2023

Summary

Fix flaky test testComplicationsWithPreRendered

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 322 lines in your changes are missing coverage. Please review.

Comparison is base (8f7f0ec) 28.37% compared to head (a6b987b) 28.25%.
Report is 2 commits behind head on master.

Files Patch % Lines
...dentialsSharing/ThreadCredentialsSharingView.swift 0.00% 117 Missing ⚠️
Sources/App/WebView/WebViewController.swift 0.00% 83 Missing ⚠️
...alsSharing/ThreadCredentialsSharingViewModel.swift 38.46% 24 Missing ⚠️
...ces/App/Settings/DebugSettingsViewController.swift 0.00% 21 Missing ⚠️
...rces/Shared/DesignSystem/Components/CardView.swift 0.00% 21 Missing ⚠️
...rces/Shared/DesignSystem/Components/HAButton.swift 0.00% 14 Missing ⚠️
Sources/Shared/Environment/MatterWrapper.swift 0.00% 12 Missing ⚠️
...ntialsSharing/ThreadCredentialsSharing+build.swift 0.00% 8 Missing ⚠️
Sources/App/AppDelegate.swift 0.00% 6 Missing ⚠️
Sources/Shared/Assets/Assets.swift 0.00% 4 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2472      +/-   ##
==========================================
- Coverage   28.37%   28.25%   -0.13%     
==========================================
  Files         273      284      +11     
  Lines       30284    30655     +371     
==========================================
+ Hits         8593     8661      +68     
- Misses      21691    21994     +303     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit bcc5574 into master Dec 7, 2023
7 checks passed
@bgoncal bgoncal deleted the fix-flaky-test branch December 7, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants