Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biometrics lock (Lock app with FaceID/TouchID/iOS Password) #2398

Closed
wants to merge 30 commits into from

Added new UI for the "lock" screen, moved some code around to a prope…

ce1f140
Select commit
Loading
Failed to load commit list.
Closed

Biometrics lock (Lock app with FaceID/TouchID/iOS Password) #2398

Added new UI for the "lock" screen, moved some code around to a prope…
ce1f140
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 7, 2023 in 0s

24.21% of diff hit (target 28.37%)

View this Pull Request on Codecov

24.21% of diff hit (target 28.37%)

Annotations

Check warning on line 27 in Sources/App/Settings/Security/SecurityViewController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/App/Settings/Security/SecurityViewController.swift#L10-L27 

Added lines #L10 - L27 were not covered by tests

Check warning on line 41 in Sources/App/Settings/SettingsRootDataSource.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/App/Settings/SettingsRootDataSource.swift#L41 

Added line #L41 was not covered by tests

Check warning on line 109 in Sources/App/Settings/SettingsRootDataSource.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/App/Settings/SettingsRootDataSource.swift#L100-L109 

Added lines #L100 - L109 were not covered by tests

Check warning on line 327 in Sources/App/WebView/WebViewController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/App/WebView/WebViewController.swift#L327 

Added line #L327 was not covered by tests

Check warning on line 350 in Sources/App/WebView/WebViewController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/App/WebView/WebViewController.swift#L350 

Added line #L350 was not covered by tests

Check warning on line 505 in Sources/App/WebView/WebViewWindowController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/App/WebView/WebViewWindowController.swift#L494-L505 

Added lines #L494 - L505 were not covered by tests

Check warning on line 517 in Sources/App/WebView/WebViewWindowController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/App/WebView/WebViewWindowController.swift#L514-L517 

Added lines #L514 - L517 were not covered by tests

Check warning on line 47 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift#L41-L47 

Added lines #L41 - L47 were not covered by tests

Check warning on line 55 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift#L53-L55 

Added lines #L53 - L55 were not covered by tests

Check warning on line 82 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift#L68-L82 

Added lines #L68 - L82 were not covered by tests

Check warning on line 88 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift#L87-L88 

Added lines #L87 - L88 were not covered by tests

Check warning on line 105 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift#L92-L105 

Added lines #L92 - L105 were not covered by tests

Check warning on line 118 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift#L107-L118 

Added lines #L107 - L118 were not covered by tests

Check warning on line 135 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift#L120-L135 

Added lines #L120 - L135 were not covered by tests

Check warning on line 141 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationService.swift#L139-L141 

Added lines #L139 - L141 were not covered by tests

Check warning on line 14 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift#L8-L14 

Added lines #L8 - L14 were not covered by tests

Check warning on line 36 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift#L16-L36 

Added lines #L16 - L36 were not covered by tests

Check warning on line 43 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift#L40-L43 

Added lines #L40 - L43 were not covered by tests

Check warning on line 47 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift#L45-L47 

Added lines #L45 - L47 were not covered by tests

Check warning on line 53 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift#L49-L53 

Added lines #L49 - L53 were not covered by tests

Check warning on line 86 in Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/LocalAuthentication/BiometricsAuthenticationViewController.swift#L55-L86 

Added lines #L55 - L86 were not covered by tests

Check warning on line 55 in Sources/Shared/Settings/SettingsStore.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Shared/Settings/SettingsStore.swift#L53-L55 

Added lines #L53 - L55 were not covered by tests
View more details on Codecov